From e9d7ea3621079ef3dbcd58393f794f19efdbd5cc Mon Sep 17 00:00:00 2001
From: Guus van Meerveld <mail@guusvanmeerveld.dev>
Date: Fri, 22 Mar 2024 13:45:10 +0100
Subject: [PATCH] fixed eslint errors

---
 .eslintrc                                       |  2 +-
 .prettierrc.json                                |  2 +-
 src/app/elements.tsx                            |  6 ++++--
 src/app/providers/index.tsx                     | 13 ++++++++-----
 src/app/results/Search.tsx                      |  6 +++---
 src/app/results/page.tsx                        |  7 +++++--
 src/app/trending/Trending.tsx                   |  2 +-
 src/app/trending/page.tsx                       |  7 +++++--
 src/app/watch/page.tsx                          |  7 +++++--
 src/client/adapters/invidious/typings/stream.ts |  1 -
 src/components/Search.tsx                       |  4 ++--
 src/components/Video.tsx                        |  6 +++---
 src/hooks/useClient.ts                          |  2 +-
 src/hooks/useContextMenuStore.ts                |  4 ++--
 src/typings/contextMenu.ts                      |  2 +-
 15 files changed, 42 insertions(+), 29 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index 89282ea..31980ba 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -11,7 +11,7 @@
 	"rules": {
 		"@typescript-eslint/no-non-null-assertion": 0,
 		"@typescript-eslint/no-unused-vars": ["error"],
-		"@typescript-eslint/explicit-function-return-type": ["error"],
+		"@typescript-eslint/explicit-function-return-type": "warn",
 		"padding-line-between-statements": [
 			"error",
 			{ "blankLine": "always", "prev": "*", "next": "block" },
diff --git a/.prettierrc.json b/.prettierrc.json
index c95839c..f96146a 100644
--- a/.prettierrc.json
+++ b/.prettierrc.json
@@ -10,7 +10,7 @@
 		"",
 		"<THIRD_PARTY_MODULES>",
 		"",
-		"^(next/.*)|(react.*)",
+		"^(next(/.*)?)|(react.*)",
 		"",
 		"^@(:?mui|nextui-org)/.*",
 		"",
diff --git a/src/app/elements.tsx b/src/app/elements.tsx
index 92de51f..8b6beb0 100644
--- a/src/app/elements.tsx
+++ b/src/app/elements.tsx
@@ -2,11 +2,13 @@
 
 import { Nav } from "@/components/Nav";
 
-export function Elements({ children }: { children: React.ReactNode }) {
+import { Component } from "@/typings/component";
+
+export const Elements: Component = ({ children }) => {
 	return (
 		<>
 			<Nav />
 			{children}
 		</>
 	);
-}
+};
diff --git a/src/app/providers/index.tsx b/src/app/providers/index.tsx
index 26a656e..e698f7e 100644
--- a/src/app/providers/index.tsx
+++ b/src/app/providers/index.tsx
@@ -6,10 +6,13 @@ import { ReactQueryDevtools } from "@tanstack/react-query-devtools";
 
 import { ContextMenuProvider } from "./ContextMenuProvider";
 
-export function Providers({ children }: { children: React.ReactNode }) {
-	const queryClient = new QueryClient({
-		defaultOptions: { queries: { retry: false } }
-	});
+import { Component } from "@/typings/component";
+
+const queryClient = new QueryClient({
+	defaultOptions: { queries: { retry: false } }
+});
+
+export const Providers: Component = ({ children }) => {
 	return (
 		<QueryClientProvider client={queryClient}>
 			<ReactQueryDevtools initialIsOpen={false} />
@@ -18,4 +21,4 @@ export function Providers({ children }: { children: React.ReactNode }) {
 			</NextUIProvider>
 		</QueryClientProvider>
 	);
-}
+};
diff --git a/src/app/results/Search.tsx b/src/app/results/Search.tsx
index eeaaedf..8202b73 100644
--- a/src/app/results/Search.tsx
+++ b/src/app/results/Search.tsx
@@ -49,7 +49,7 @@ export const Search: Component = () => {
 		data,
 		error: fetchError,
 		fetchNextPage,
-		hasNextPage,
+		// hasNextPage,
 		refetch,
 		isFetching,
 		isFetchingNextPage
@@ -63,7 +63,7 @@ export const Search: Component = () => {
 		},
 		enabled: !!invalidQuery || !!invalidFilter,
 		initialPageParam: "",
-		getNextPageParam: (lastPage, pages) => lastPage.nextCursor
+		getNextPageParam: (lastPage) => lastPage.nextCursor
 	});
 
 	const error = invalidQuery ?? invalidFilter ?? fetchError ?? undefined;
@@ -81,7 +81,7 @@ export const Search: Component = () => {
 		(visiblity: boolean) => {
 			if (visiblity && !isFetchingNextPage) fetchNextPage();
 		},
-		[hasNextPage, isFetchingNextPage, fetchNextPage]
+		[isFetchingNextPage, fetchNextPage]
 	);
 
 	return (
diff --git a/src/app/results/page.tsx b/src/app/results/page.tsx
index 0e59af8..330af9e 100644
--- a/src/app/results/page.tsx
+++ b/src/app/results/page.tsx
@@ -1,8 +1,9 @@
+import { NextPage } from "next";
 import { Suspense } from "react";
 
 import { Search } from "./Search";
 
-export default function Page() {
+const Page: NextPage = () => {
 	return (
 		<>
 			<Suspense>
@@ -10,4 +11,6 @@ export default function Page() {
 			</Suspense>
 		</>
 	);
-}
+};
+
+export default Page;
diff --git a/src/app/trending/Trending.tsx b/src/app/trending/Trending.tsx
index ddc6060..cb4764b 100644
--- a/src/app/trending/Trending.tsx
+++ b/src/app/trending/Trending.tsx
@@ -47,7 +47,7 @@ export const Trending: Component = ({}) => {
 		refetch,
 		data
 	} = useQuery({
-		queryKey: ["trending", region?.code],
+		queryKey: ["trending", region],
 		queryFn: () => {
 			if (region === null) return;
 
diff --git a/src/app/trending/page.tsx b/src/app/trending/page.tsx
index b40716e..99a4fd4 100644
--- a/src/app/trending/page.tsx
+++ b/src/app/trending/page.tsx
@@ -1,10 +1,11 @@
+import { NextPage } from "next";
 import { Suspense } from "react";
 
 import { LoadingPage } from "@/components/LoadingPage";
 
 import { Trending } from "./Trending";
 
-export default function Page() {
+const Page: NextPage = () => {
 	return (
 		<>
 			<Suspense fallback={<LoadingPage />}>
@@ -12,4 +13,6 @@ export default function Page() {
 			</Suspense>
 		</>
 	);
-}
+};
+
+export default Page;
diff --git a/src/app/watch/page.tsx b/src/app/watch/page.tsx
index a119c0c..0b34f31 100644
--- a/src/app/watch/page.tsx
+++ b/src/app/watch/page.tsx
@@ -1,8 +1,9 @@
+import { NextPage } from "next";
 import { Suspense } from "react";
 
 import { Watch } from "./Watch";
 
-export default function Page() {
+const Page: NextPage = () => {
 	return (
 		<>
 			<Suspense>
@@ -10,4 +11,6 @@ export default function Page() {
 			</Suspense>
 		</>
 	);
-}
+};
+
+export default Page;
diff --git a/src/client/adapters/invidious/typings/stream.ts b/src/client/adapters/invidious/typings/stream.ts
index 93afbb8..925518a 100644
--- a/src/client/adapters/invidious/typings/stream.ts
+++ b/src/client/adapters/invidious/typings/stream.ts
@@ -2,7 +2,6 @@ import z from "zod";
 
 import { StoryboardModel } from "./storyboard";
 import { AuthorThumbnailModel, ThumbnailModel } from "./thumbnail";
-import { VideoModel } from "./video";
 
 export const AdaptiveFormatModel = z.object({
 	index: z.string(),
diff --git a/src/components/Search.tsx b/src/components/Search.tsx
index 405e856..eade196 100644
--- a/src/components/Search.tsx
+++ b/src/components/Search.tsx
@@ -3,7 +3,7 @@
 import { useDebounce } from "use-debounce";
 
 import { useQuery } from "@tanstack/react-query";
-import { useCallback, useMemo, useState } from "react";
+import { useMemo, useState } from "react";
 import { FiSearch as SearchIcon } from "react-icons/fi";
 
 import { Autocomplete, AutocompleteItem } from "@nextui-org/autocomplete";
@@ -33,7 +33,7 @@ export const Search: Component<{
 		}
 	});
 
-	const submit = (query: string) => {
+	const submit = (query: string): void => {
 		searchFor(query);
 	};
 
diff --git a/src/components/Video.tsx b/src/components/Video.tsx
index 424dfc2..632ec9a 100644
--- a/src/components/Video.tsx
+++ b/src/components/Video.tsx
@@ -28,7 +28,7 @@ export const Video: Component<{ data: VideoProps }> = ({ data }) => {
 		{
 			title: "Copy video id",
 			key: "videoId",
-			onClick: () => {
+			onClick: (): void => {
 				navigator.clipboard.writeText(data.id);
 			},
 			showDivider: true
@@ -41,7 +41,7 @@ export const Video: Component<{ data: VideoProps }> = ({ data }) => {
 		{
 			title: "Copy thumnail url",
 			key: "thumbnailUrl",
-			onClick: () => {
+			onClick: (): void => {
 				navigator.clipboard.writeText(data.thumbnail);
 			},
 			showDivider: true
@@ -54,7 +54,7 @@ export const Video: Component<{ data: VideoProps }> = ({ data }) => {
 		{
 			title: "Copy channel id",
 			key: "channelId",
-			onClick: () => {
+			onClick: (): void => {
 				navigator.clipboard.writeText(data.author.id);
 			}
 		}
diff --git a/src/hooks/useClient.ts b/src/hooks/useClient.ts
index 3a97878..78e63c7 100644
--- a/src/hooks/useClient.ts
+++ b/src/hooks/useClient.ts
@@ -3,7 +3,7 @@ import { useState } from "react";
 import Client from "@/client";
 import { ApiType } from "@/client/adapters";
 
-export const useClient = () => {
+export const useClient = (): Client => {
 	const [client] = useState(
 		() =>
 			new Client([
diff --git a/src/hooks/useContextMenuStore.ts b/src/hooks/useContextMenuStore.ts
index 1447ef7..9a5b51b 100644
--- a/src/hooks/useContextMenuStore.ts
+++ b/src/hooks/useContextMenuStore.ts
@@ -19,10 +19,10 @@ const useContextMenuStore = create<ContextMenuStore>((set) => ({
 	show: false,
 	location: { x: 0, y: 0 },
 	items: [],
-	showContextMenu(x, y, items) {
+	showContextMenu: (x, y, items): void => {
 		set({ show: true, location: { x, y }, items });
 	},
-	hide: () => set({ show: false })
+	hide: (): void => set({ show: false })
 }));
 
 export default useContextMenuStore;
diff --git a/src/typings/contextMenu.ts b/src/typings/contextMenu.ts
index 97ec625..65859d1 100644
--- a/src/typings/contextMenu.ts
+++ b/src/typings/contextMenu.ts
@@ -3,5 +3,5 @@ export interface ContextMenuItem {
 	key: string;
 	showDivider?: boolean;
 	href?: string;
-	onClick?: () => any;
+	onClick?: () => unknown;
 }